* [PATCH net v1] netlink: specs: Add missing bridge linkinfo attrs
@ 2024-05-03 16:43 Donald Hunter
2024-05-03 16:53 ` Nikolay Aleksandrov
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Donald Hunter @ 2024-05-03 16:43 UTC (permalink / raw)
To: netdev, Jakub Kicinski, David S. Miller, Eric Dumazet,
Paolo Abeni, Jiri Pirko, Jacob Keller, Johannes Nixdorf,
Ido Schimmel, Nikolay Aleksandrov
Cc: donald.hunter, Donald Hunter
Attributes for FDB learned entries were added to the if_link netlink api
for bridge linkinfo but are missing from the rt_link.yaml spec. Add the
missing attributes to the spec.
Fixes: ddd1ad68826d ("net: bridge: Add netlink knobs for number / max learned FDB entries")
Signed-off-by: Donald Hunter <donald.hunter@gmail.com>
---
Documentation/netlink/specs/rt_link.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/netlink/specs/rt_link.yaml b/Documentation/netlink/specs/rt_link.yaml
index 8e4d19adee8c..4e702ac8bf66 100644
--- a/Documentation/netlink/specs/rt_link.yaml
+++ b/Documentation/netlink/specs/rt_link.yaml
@@ -1144,6 +1144,12 @@ attribute-sets:
-
name: mcast-querier-state
type: binary
+ -
+ name: fdb-n-learned
+ type: u32
+ -
+ name: fdb-max-learned
+ type: u32
-
name: linkinfo-brport-attrs
name-prefix: ifla-brport-
--
2.44.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net v1] netlink: specs: Add missing bridge linkinfo attrs
2024-05-03 16:43 [PATCH net v1] netlink: specs: Add missing bridge linkinfo attrs Donald Hunter
@ 2024-05-03 16:53 ` Nikolay Aleksandrov
2024-05-03 18:15 ` Keller, Jacob E
2024-05-07 2:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Nikolay Aleksandrov @ 2024-05-03 16:53 UTC (permalink / raw)
To: Donald Hunter, netdev, Jakub Kicinski, David S. Miller,
Eric Dumazet, Paolo Abeni, Jiri Pirko, Jacob Keller,
Johannes Nixdorf, Ido Schimmel
Cc: donald.hunter
On 03/05/2024 19:43, Donald Hunter wrote:
> Attributes for FDB learned entries were added to the if_link netlink api
> for bridge linkinfo but are missing from the rt_link.yaml spec. Add the
> missing attributes to the spec.
>
> Fixes: ddd1ad68826d ("net: bridge: Add netlink knobs for number / max learned FDB entries")
> Signed-off-by: Donald Hunter <donald.hunter@gmail.com>
> ---
> Documentation/netlink/specs/rt_link.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/netlink/specs/rt_link.yaml b/Documentation/netlink/specs/rt_link.yaml
> index 8e4d19adee8c..4e702ac8bf66 100644
> --- a/Documentation/netlink/specs/rt_link.yaml
> +++ b/Documentation/netlink/specs/rt_link.yaml
> @@ -1144,6 +1144,12 @@ attribute-sets:
> -
> name: mcast-querier-state
> type: binary
> + -
> + name: fdb-n-learned
> + type: u32
> + -
> + name: fdb-max-learned
> + type: u32
> -
> name: linkinfo-brport-attrs
> name-prefix: ifla-brport-
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH net v1] netlink: specs: Add missing bridge linkinfo attrs
2024-05-03 16:43 [PATCH net v1] netlink: specs: Add missing bridge linkinfo attrs Donald Hunter
2024-05-03 16:53 ` Nikolay Aleksandrov
@ 2024-05-03 18:15 ` Keller, Jacob E
2024-05-07 2:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Keller, Jacob E @ 2024-05-03 18:15 UTC (permalink / raw)
To: Donald Hunter, netdev, Jakub Kicinski, David S. Miller,
Eric Dumazet, Paolo Abeni, Jiri Pirko, Johannes Nixdorf,
Ido Schimmel, Nikolay Aleksandrov
Cc: donald.hunter
> -----Original Message-----
> From: Donald Hunter <donald.hunter@gmail.com>
> Sent: Friday, May 3, 2024 9:43 AM
> To: netdev@vger.kernel.org; Jakub Kicinski <kuba@kernel.org>; David S. Miller
> <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Paolo Abeni
> <pabeni@redhat.com>; Jiri Pirko <jiri@resnulli.us>; Keller, Jacob E
> <jacob.e.keller@intel.com>; Johannes Nixdorf <jnixdorf-oss@avm.de>; Ido
> Schimmel <idosch@nvidia.com>; Nikolay Aleksandrov <razor@blackwall.org>
> Cc: donald.hunter@redhat.com; Donald Hunter <donald.hunter@gmail.com>
> Subject: [PATCH net v1] netlink: specs: Add missing bridge linkinfo attrs
>
> Attributes for FDB learned entries were added to the if_link netlink api
> for bridge linkinfo but are missing from the rt_link.yaml spec. Add the
> missing attributes to the spec.
>
> Fixes: ddd1ad68826d ("net: bridge: Add netlink knobs for number / max learned
> FDB entries")
> Signed-off-by: Donald Hunter <donald.hunter@gmail.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> ---
> Documentation/netlink/specs/rt_link.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/netlink/specs/rt_link.yaml
> b/Documentation/netlink/specs/rt_link.yaml
> index 8e4d19adee8c..4e702ac8bf66 100644
> --- a/Documentation/netlink/specs/rt_link.yaml
> +++ b/Documentation/netlink/specs/rt_link.yaml
> @@ -1144,6 +1144,12 @@ attribute-sets:
> -
> name: mcast-querier-state
> type: binary
> + -
> + name: fdb-n-learned
> + type: u32
> + -
> + name: fdb-max-learned
> + type: u32
> -
> name: linkinfo-brport-attrs
> name-prefix: ifla-brport-
> --
> 2.44.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net v1] netlink: specs: Add missing bridge linkinfo attrs
2024-05-03 16:43 [PATCH net v1] netlink: specs: Add missing bridge linkinfo attrs Donald Hunter
2024-05-03 16:53 ` Nikolay Aleksandrov
2024-05-03 18:15 ` Keller, Jacob E
@ 2024-05-07 2:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-05-07 2:50 UTC (permalink / raw)
To: Donald Hunter
Cc: netdev, kuba, davem, edumazet, pabeni, jiri, jacob.e.keller,
jnixdorf-oss, idosch, razor, donald.hunter
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 3 May 2024 17:43:04 +0100 you wrote:
> Attributes for FDB learned entries were added to the if_link netlink api
> for bridge linkinfo but are missing from the rt_link.yaml spec. Add the
> missing attributes to the spec.
>
> Fixes: ddd1ad68826d ("net: bridge: Add netlink knobs for number / max learned FDB entries")
> Signed-off-by: Donald Hunter <donald.hunter@gmail.com>
>
> [...]
Here is the summary with links:
- [net,v1] netlink: specs: Add missing bridge linkinfo attrs
https://git.kernel.org/netdev/net/c/9adcac650618
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-05-07 2:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-03 16:43 [PATCH net v1] netlink: specs: Add missing bridge linkinfo attrs Donald Hunter
2024-05-03 16:53 ` Nikolay Aleksandrov
2024-05-03 18:15 ` Keller, Jacob E
2024-05-07 2:50 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.