* [PATCH] [PATCH v2 net-next] mptcp: fix typos in comments
@ 2024-05-02 15:47 Shi-Sheng Yang
2024-05-02 16:40 ` MPTCP CI
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Shi-Sheng Yang @ 2024-05-02 15:47 UTC (permalink / raw)
To: matttbe, martineau, davem, edumazet, kuba, pabeni
Cc: geliang, netdev, mptcp, linux-kernel, Shi-Sheng Yang
This patch fixes the spelling mistakes in comments.
The changes were generated using codespell and reviewed manually.
eariler -> earlier
greceful -> graceful
Signed-off-by: Shi-Sheng Yang <fourcolor4c@gmail.com>
---
net/mptcp/subflow.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c
index 97ec44d1df30..0ac8d4850751 100644
--- a/net/mptcp/subflow.c
+++ b/net/mptcp/subflow.c
@@ -911,7 +911,7 @@ static struct sock *subflow_syn_recv_sock(const struct sock *sk,
}
/* check for expected invariant - should never trigger, just help
- * catching eariler subtle bugs
+ * catching earlier subtle bugs
*/
WARN_ON_ONCE(child && *own_req && tcp_sk(child)->is_mptcp &&
(!mptcp_subflow_ctx(child) ||
@@ -1259,7 +1259,7 @@ static void mptcp_subflow_fail(struct mptcp_sock *msk, struct sock *ssk)
struct mptcp_subflow_context *subflow = mptcp_subflow_ctx(ssk);
unsigned long fail_tout;
- /* greceful failure can happen only on the MPC subflow */
+ /* graceful failure can happen only on the MPC subflow */
if (WARN_ON_ONCE(ssk != READ_ONCE(msk->first)))
return;
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] [PATCH v2 net-next] mptcp: fix typos in comments
2024-05-02 15:47 [PATCH] [PATCH v2 net-next] mptcp: fix typos in comments Shi-Sheng Yang
@ 2024-05-02 16:40 ` MPTCP CI
2024-05-04 10:58 ` Simon Horman
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: MPTCP CI @ 2024-05-02 16:40 UTC (permalink / raw)
To: Shi-Sheng Yang; +Cc: mptcp
Hi Shi-Sheng,
Thank you for your modifications, that's great!
Our CI did some validations and here is its report:
- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/8926914986
Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/a9a443be8da7
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=849948
If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:
$ cd [kernel source code]
$ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
--pull always mptcp/mptcp-upstream-virtme-docker:latest \
auto-normal
For more details:
https://github.com/multipath-tcp/mptcp-upstream-virtme-docker
Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)
Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] [PATCH v2 net-next] mptcp: fix typos in comments
2024-05-02 15:47 [PATCH] [PATCH v2 net-next] mptcp: fix typos in comments Shi-Sheng Yang
2024-05-02 16:40 ` MPTCP CI
@ 2024-05-04 10:58 ` Simon Horman
2024-05-06 7:40 ` Matthieu Baerts
2024-05-07 2:50 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2024-05-04 10:58 UTC (permalink / raw)
To: Shi-Sheng Yang
Cc: matttbe, martineau, davem, edumazet, kuba, pabeni, geliang,
netdev, mptcp, linux-kernel
On Thu, May 02, 2024 at 11:47:40PM +0800, Shi-Sheng Yang wrote:
> This patch fixes the spelling mistakes in comments.
> The changes were generated using codespell and reviewed manually.
>
> eariler -> earlier
> greceful -> graceful
>
> Signed-off-by: Shi-Sheng Yang <fourcolor4c@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] [PATCH v2 net-next] mptcp: fix typos in comments
2024-05-02 15:47 [PATCH] [PATCH v2 net-next] mptcp: fix typos in comments Shi-Sheng Yang
2024-05-02 16:40 ` MPTCP CI
2024-05-04 10:58 ` Simon Horman
@ 2024-05-06 7:40 ` Matthieu Baerts
2024-05-07 2:50 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: Matthieu Baerts @ 2024-05-06 7:40 UTC (permalink / raw)
To: Shi-Sheng Yang, davem, kuba, pabeni, Simon Horman
Cc: geliang, netdev, mptcp, linux-kernel, martineau, edumazet
Hi Shi-Sheng,
On 02/05/2024 17:47, Shi-Sheng Yang wrote:
> This patch fixes the spelling mistakes in comments.
> The changes were generated using codespell and reviewed manually.
>
> eariler -> earlier
> greceful -> graceful
Thank you for the fix, it looks good to me:
Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
@Simon: many thanks for the previous review!
@Netdev maintainers: I think it is best to apply this patch -- and
similar ones -- directly in the Netdev tree, no need to have it first in
the MPTCP tree.
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] [PATCH v2 net-next] mptcp: fix typos in comments
2024-05-02 15:47 [PATCH] [PATCH v2 net-next] mptcp: fix typos in comments Shi-Sheng Yang
` (2 preceding siblings ...)
2024-05-06 7:40 ` Matthieu Baerts
@ 2024-05-07 2:50 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-05-07 2:50 UTC (permalink / raw)
To: Shi-Sheng Yang
Cc: matttbe, martineau, davem, edumazet, kuba, pabeni, geliang,
netdev, mptcp, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 2 May 2024 23:47:40 +0800 you wrote:
> This patch fixes the spelling mistakes in comments.
> The changes were generated using codespell and reviewed manually.
>
> eariler -> earlier
> greceful -> graceful
>
> Signed-off-by: Shi-Sheng Yang <fourcolor4c@gmail.com>
>
> [...]
Here is the summary with links:
- [v2,net-next] mptcp: fix typos in comments
https://git.kernel.org/netdev/net-next/c/46a5d3abedbe
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-05-07 2:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-02 15:47 [PATCH] [PATCH v2 net-next] mptcp: fix typos in comments Shi-Sheng Yang
2024-05-02 16:40 ` MPTCP CI
2024-05-04 10:58 ` Simon Horman
2024-05-06 7:40 ` Matthieu Baerts
2024-05-07 2:50 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.