All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amdgpu: ignoring unsupported ras blocks when MCA bank dispatches
@ 2024-05-06  6:47 Yang Wang
  2024-05-07  1:36 ` Wang, Yang(Kevin)
  0 siblings, 1 reply; 3+ messages in thread
From: Yang Wang @ 2024-05-06  6:47 UTC (permalink / raw)
  To: amd-gfx; +Cc: hawking.zhang, tao.zhou1, candice.li

This patch is used to solve the problem of incorrect parsing of error counts.
When the UE trigger gpu is reset, the driver will attempt to parse all possible ras blocks.
For ras blocks that are not supported by the current ASIC, the driver should ignore this error.

Signed-off-by: Yang Wang <kevinyang.wang@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_mca.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mca.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_mca.c
index a7736aa58ba9..0c9a271c5028 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mca.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mca.c
@@ -415,7 +415,7 @@ static int amdgpu_mca_dispatch_mca_set(struct amdgpu_device *adev, enum amdgpu_r
 
 		count = 0;
 		ret = amdgpu_mca_smu_parse_mca_error_count(adev, blk, type, entry, &count);
-		if (ret)
+		if (ret && ret != -EOPNOTSUPP)
 			return ret;
 
 		if (!count)
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [PATCH] drm/amdgpu: ignoring unsupported ras blocks when MCA bank dispatches
  2024-05-06  6:47 [PATCH] drm/amdgpu: ignoring unsupported ras blocks when MCA bank dispatches Yang Wang
@ 2024-05-07  1:36 ` Wang, Yang(Kevin)
  2024-05-07  2:17   ` Li, Candice
  0 siblings, 1 reply; 3+ messages in thread
From: Wang, Yang(Kevin) @ 2024-05-07  1:36 UTC (permalink / raw)
  To: Wang, Yang(Kevin), amd-gfx
  Cc: Zhang, Hawking, Zhou1, Tao, Li, Candice, Zhou, Hao (Claire)

Ping...

Best Regards,
Kevin

-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Yang Wang
Sent: 2024年5月6日 14:47
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking <Hawking.Zhang@amd.com>; Zhou1, Tao <Tao.Zhou1@amd.com>; Li, Candice <Candice.Li@amd.com>
Subject: [PATCH] drm/amdgpu: ignoring unsupported ras blocks when MCA bank dispatches

This patch is used to solve the problem of incorrect parsing of error counts.
When the UE trigger gpu is reset, the driver will attempt to parse all possible ras blocks.
For ras blocks that are not supported by the current ASIC, the driver should ignore this error.

Signed-off-by: Yang Wang <kevinyang.wang@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_mca.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mca.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_mca.c
index a7736aa58ba9..0c9a271c5028 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mca.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mca.c
@@ -415,7 +415,7 @@ static int amdgpu_mca_dispatch_mca_set(struct amdgpu_device *adev, enum amdgpu_r
 
 		count = 0;
 		ret = amdgpu_mca_smu_parse_mca_error_count(adev, blk, type, entry, &count);
-		if (ret)
+		if (ret && ret != -EOPNOTSUPP)
 			return ret;
 
 		if (!count)
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [PATCH] drm/amdgpu: ignoring unsupported ras blocks when MCA bank dispatches
  2024-05-07  1:36 ` Wang, Yang(Kevin)
@ 2024-05-07  2:17   ` Li, Candice
  0 siblings, 0 replies; 3+ messages in thread
From: Li, Candice @ 2024-05-07  2:17 UTC (permalink / raw)
  To: Wang, Yang(Kevin), amd-gfx; +Cc: Zhang, Hawking, Zhou1, Tao, Zhou, Hao (Claire)

[AMD Official Use Only - General]

Reviewed-by: Candice Li <candice.li@amd.com>



Thanks,
Candice

-----Original Message-----
From: Wang, Yang(Kevin) <KevinYang.Wang@amd.com>
Sent: Tuesday, May 7, 2024 9:36 AM
To: Wang, Yang(Kevin) <KevinYang.Wang@amd.com>; amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking <Hawking.Zhang@amd.com>; Zhou1, Tao <Tao.Zhou1@amd.com>; Li, Candice <Candice.Li@amd.com>; Zhou, Hao (Claire) <Hao.Zhou@amd.com>
Subject: RE: [PATCH] drm/amdgpu: ignoring unsupported ras blocks when MCA bank dispatches

Ping...

Best Regards,
Kevin

-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Yang Wang
Sent: 2024年5月6日 14:47
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking <Hawking.Zhang@amd.com>; Zhou1, Tao <Tao.Zhou1@amd.com>; Li, Candice <Candice.Li@amd.com>
Subject: [PATCH] drm/amdgpu: ignoring unsupported ras blocks when MCA bank dispatches

This patch is used to solve the problem of incorrect parsing of error counts.
When the UE trigger gpu is reset, the driver will attempt to parse all possible ras blocks.
For ras blocks that are not supported by the current ASIC, the driver should ignore this error.

Signed-off-by: Yang Wang <kevinyang.wang@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_mca.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mca.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_mca.c
index a7736aa58ba9..0c9a271c5028 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mca.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mca.c
@@ -415,7 +415,7 @@ static int amdgpu_mca_dispatch_mca_set(struct amdgpu_device *adev, enum amdgpu_r

                count = 0;
                ret = amdgpu_mca_smu_parse_mca_error_count(adev, blk, type, entry, &count);
-               if (ret)
+               if (ret && ret != -EOPNOTSUPP)
                        return ret;

                if (!count)
--
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-05-07  2:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-06  6:47 [PATCH] drm/amdgpu: ignoring unsupported ras blocks when MCA bank dispatches Yang Wang
2024-05-07  1:36 ` Wang, Yang(Kevin)
2024-05-07  2:17   ` Li, Candice

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.