* [PATCH] Revert "ext4: apply umask if ACL support is disabled"
@ 2024-03-15 14:29 Max Kellermann
2024-03-18 8:44 ` Christian Brauner
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Max Kellermann @ 2024-03-15 14:29 UTC (permalink / raw)
To: tytso, adilger.kernel, linux-ext4, linux-kernel, brauner, mforney
Cc: stable, Max Kellermann
This reverts commit 484fd6c1de13b336806a967908a927cc0356e312. The
commit caused a regression because now the umask was applied to
symlinks and the fix is unnecessary because the umask/O_TMPFILE bug
has been fixed somewhere else already.
Fixes: https://lore.kernel.org/lkml/28DSITL9912E1.2LSZUVTGTO52Q@mforney.org/
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
---
fs/ext4/acl.h | 5 -----
1 file changed, 5 deletions(-)
diff --git a/fs/ext4/acl.h b/fs/ext4/acl.h
index ef4c19e5f570..0c5a79c3b5d4 100644
--- a/fs/ext4/acl.h
+++ b/fs/ext4/acl.h
@@ -68,11 +68,6 @@ extern int ext4_init_acl(handle_t *, struct inode *, struct inode *);
static inline int
ext4_init_acl(handle_t *handle, struct inode *inode, struct inode *dir)
{
- /* usually, the umask is applied by posix_acl_create(), but if
- ext4 ACL support is disabled at compile time, we need to do
- it here, because posix_acl_create() will never be called */
- inode->i_mode &= ~current_umask();
-
return 0;
}
#endif /* CONFIG_EXT4_FS_POSIX_ACL */
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Revert "ext4: apply umask if ACL support is disabled"
2024-03-15 14:29 [PATCH] Revert "ext4: apply umask if ACL support is disabled" Max Kellermann
@ 2024-03-18 8:44 ` Christian Brauner
2024-03-25 0:22 ` Michael Forney
2024-05-02 22:26 ` Theodore Ts'o
2 siblings, 0 replies; 5+ messages in thread
From: Christian Brauner @ 2024-03-18 8:44 UTC (permalink / raw)
To: Max Kellermann
Cc: tytso, adilger.kernel, linux-ext4, linux-kernel, mforney, stable
On Fri, Mar 15, 2024 at 03:29:56PM +0100, Max Kellermann wrote:
> This reverts commit 484fd6c1de13b336806a967908a927cc0356e312. The
> commit caused a regression because now the umask was applied to
> symlinks and the fix is unnecessary because the umask/O_TMPFILE bug
> has been fixed somewhere else already.
>
> Fixes: https://lore.kernel.org/lkml/28DSITL9912E1.2LSZUVTGTO52Q@mforney.org/
> Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
> ---
Looks good to me,
Reviewed-by: Christian Brauner <brauner@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Revert "ext4: apply umask if ACL support is disabled"
2024-03-15 14:29 [PATCH] Revert "ext4: apply umask if ACL support is disabled" Max Kellermann
2024-03-18 8:44 ` Christian Brauner
@ 2024-03-25 0:22 ` Michael Forney
2024-05-01 20:04 ` Michael Forney
2024-05-02 22:26 ` Theodore Ts'o
2 siblings, 1 reply; 5+ messages in thread
From: Michael Forney @ 2024-03-25 0:22 UTC (permalink / raw)
To: Max Kellermann
Cc: tytso, adilger.kernel, linux-ext4, linux-kernel, brauner, stable
Max Kellermann <max.kellermann@ionos.com> wrote:
> This reverts commit 484fd6c1de13b336806a967908a927cc0356e312. The
> commit caused a regression because now the umask was applied to
> symlinks and the fix is unnecessary because the umask/O_TMPFILE bug
> has been fixed somewhere else already.
Thanks, Max! I've verified that this fixes symlink modes for me,
as well as the flatpak corruption error I was getting.
> Fixes: https://lore.kernel.org/lkml/28DSITL9912E1.2LSZUVTGTO52Q@mforney.org/
> Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
Tested-by: Michael Forney <mforney@mforney.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Revert "ext4: apply umask if ACL support is disabled"
2024-03-25 0:22 ` Michael Forney
@ 2024-05-01 20:04 ` Michael Forney
0 siblings, 0 replies; 5+ messages in thread
From: Michael Forney @ 2024-05-01 20:04 UTC (permalink / raw)
To: Michael Forney
Cc: Max Kellermann, tytso, adilger.kernel, linux-ext4, linux-kernel,
brauner, stable
Michael Forney <mforney@mforney.org> wrote:
> Max Kellermann <max.kellermann@ionos.com> wrote:
> > This reverts commit 484fd6c1de13b336806a967908a927cc0356e312. The
> > commit caused a regression because now the umask was applied to
> > symlinks and the fix is unnecessary because the umask/O_TMPFILE bug
> > has been fixed somewhere else already.
>
> Thanks, Max! I've verified that this fixes symlink modes for me,
> as well as the flatpak corruption error I was getting.
>
> > Fixes: https://lore.kernel.org/lkml/28DSITL9912E1.2LSZUVTGTO52Q@mforney.org/
> > Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
>
> Tested-by: Michael Forney <mforney@mforney.org>
Just checking in on this. I'd really like to see this regression
fixed. It currently affects versions 6.5 through 6.9-rc6 as well
as all longterm releases.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Revert "ext4: apply umask if ACL support is disabled"
2024-03-15 14:29 [PATCH] Revert "ext4: apply umask if ACL support is disabled" Max Kellermann
2024-03-18 8:44 ` Christian Brauner
2024-03-25 0:22 ` Michael Forney
@ 2024-05-02 22:26 ` Theodore Ts'o
2 siblings, 0 replies; 5+ messages in thread
From: Theodore Ts'o @ 2024-05-02 22:26 UTC (permalink / raw)
To: adilger.kernel, linux-ext4, linux-kernel, brauner, mforney,
Max Kellermann
Cc: Theodore Ts'o, stable
On Fri, 15 Mar 2024 15:29:56 +0100, Max Kellermann wrote:
> This reverts commit 484fd6c1de13b336806a967908a927cc0356e312. The
> commit caused a regression because now the umask was applied to
> symlinks and the fix is unnecessary because the umask/O_TMPFILE bug
> has been fixed somewhere else already.
>
>
Applied, thanks!
[1/1] Revert "ext4: apply umask if ACL support is disabled"
commit: c77194965dd0dcc26f9c1671d2e74e4eb1248af5
Best regards,
--
Theodore Ts'o <tytso@mit.edu>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-05-02 22:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-15 14:29 [PATCH] Revert "ext4: apply umask if ACL support is disabled" Max Kellermann
2024-03-18 8:44 ` Christian Brauner
2024-03-25 0:22 ` Michael Forney
2024-05-01 20:04 ` Michael Forney
2024-05-02 22:26 ` Theodore Ts'o
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.